[ 
https://issues.apache.org/jira/browse/SOLR-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vitaliy Zhovtyuk updated SOLR-6452:
-----------------------------------
    Attachment: SOLR-6452.patch

There are few issues in committed code addressed in attached patch:
1. Accumulate methods should not return stats specific numbers (it is generic 
calculation).
Attached solution with nested container class.
Also made them private scoped.

2. Reduced visibility of fields in FieldFacetStats.
Created getter to expose FieldFacetStats.facetStatsValues.

3. Methods FieldFacetStats#accumulateMissing and 
FieldFacetStats#accumulateTermNum does not throw any IO exception

4. Why missing facet counters cant work on StatsValues directly without 
intermediate maps. They have all required required methods that look like 
duplicated in org.apache.solr.handler.component.FieldFacetStats#facetMissingNum 
and org.apache.solr.handler.component.AbstractStatsValues#missing?
Will try to unite it.

> StatsComponent "missing" stat won't work with docValues=true and indexed=false
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-6452
>                 URL: https://issues.apache.org/jira/browse/SOLR-6452
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.10, 5.0
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Tomás Fernández Löbbe
>         Attachments: SOLR-6452-trunk.patch, SOLR-6452-trunk.patch, 
> SOLR-6452.patch, SOLR-6452.patch, SOLR-6452.patch
>
>
> StatsComponent can work with DocValues, but it still required to use 
> indexed=true for the "missing" stat to work. Missing values should be 
> obtained from the docValues too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to