[
https://issues.apache.org/jira/browse/SOLR-6452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vitaliy Zhovtyuk updated SOLR-6452:
-----------------------------------
Attachment: SOLR-6452-trunk.patch
Added patch based on trunk.
Added facet fields tests for integer and double types, and facet value stats is
not available. Does it require new issue or reopen SOLR-6452?
Implementation of this issue can be improved in few cases:
1. Accumulate methods should not return stats specific numbers (it is generic).
Attached solution with container class. Also made them private scoped.
Returning just missing fields from accumulate methods does not allow you to
extend it with additional counts field, therefore i propose to leave void.
2. Reduced visibility of fields in FieldFacetStats.
Created getter to expose FieldFacetStats.facetStatsValues.
3. Methods FieldFacetStats#accumulateMissing and
FieldFacetStats#accumulateTermNum does not throw any IO exception
4. We don't need intermediate maps to accumulate missing counts. Changed
org.apache.solr.handler.component.FieldFacetStats#facetMissingNum
to work directly on StatsValues structure and removed
org.apache.solr.handler.component.FieldFacetStats#accumulateMissing.
We don't need to have it in 2 phases.
> StatsComponent "missing" stat won't work with docValues=true and indexed=false
> ------------------------------------------------------------------------------
>
> Key: SOLR-6452
> URL: https://issues.apache.org/jira/browse/SOLR-6452
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.10, 5.0
> Reporter: Tomás Fernández Löbbe
> Assignee: Tomás Fernández Löbbe
> Fix For: 4.11, 5.0
>
> Attachments: SOLR-6452-trunk.patch, SOLR-6452-trunk.patch,
> SOLR-6452-trunk.patch, SOLR-6452.patch, SOLR-6452.patch, SOLR-6452.patch
>
>
> StatsComponent can work with DocValues, but it still required to use
> indexed=true for the "missing" stat to work. Missing values should be
> obtained from the docValues too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
