[
https://issues.apache.org/jira/browse/SOLR-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134948#comment-14134948
]
Shalin Shekhar Mangar commented on SOLR-6115:
---------------------------------------------
All tests and precommit pass. I'll commit this soon.
> Cleanup enum/string action types in Overseer, OverseerCollectionProcessor and
> CollectionHandler
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-6115
> URL: https://issues.apache.org/jira/browse/SOLR-6115
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-6115.patch
>
>
> The enum/string handling for actions in Overseer and OCP is a mess. We should
> fix it.
> From:
> https://issues.apache.org/jira/browse/SOLR-5466?focusedCommentId=13918059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13918059
> {quote}
> I started to untangle the fact that we have all the strings in
> OverseerCollectionProcessor, but also have a nice CollectionAction enum. And
> the commands are intermingled with parameters, it all seems rather confusing.
> Does it make sense to use the enum rather than the strings? Or somehow
> associate the two? Probably something for another JIRA though...
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
