[
https://issues.apache.org/jira/browse/SOLR-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138981#comment-14138981
]
Erick Erickson commented on SOLR-6115:
--------------------------------------
And thank _you_. I just ran into all this again yesterday, I had stuff
scattered all over the place for some new functionality and thought "that makes
no sense, I'll...". So I fixed up the bits that I had been added, probably
should have waited a day ;)....
It'll be cool to have all this straightened out! I'm sure there were places all
over...
> Cleanup enum/string action types in Overseer, OverseerCollectionProcessor and
> CollectionHandler
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-6115
> URL: https://issues.apache.org/jira/browse/SOLR-6115
> Project: Solr
> Issue Type: Task
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: 5.0, 6.0
>
> Attachments: SOLR-6115-branch_4x.patch, SOLR-6115.patch
>
>
> The enum/string handling for actions in Overseer and OCP is a mess. We should
> fix it.
> From:
> https://issues.apache.org/jira/browse/SOLR-5466?focusedCommentId=13918059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13918059
> {quote}
> I started to untangle the fact that we have all the strings in
> OverseerCollectionProcessor, but also have a nice CollectionAction enum. And
> the commands are intermingled with parameters, it all seems rather confusing.
> Does it make sense to use the enum rather than the strings? Or somehow
> associate the two? Probably something for another JIRA though...
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
