-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25658/
-----------------------------------------------------------
(Updated Sept. 16, 2014, 9:40 p.m.)
Review request for lucene.
Changes
-------
Changed the design to have an abstract/base QueryTimeout class and
implementations that use local var and ThreadLocal for Lucene/Solr. Changed the
Lucene test to use the non-ThreadLocal implementation and SolrIndexSearcher
uses the ThreadLocal implementation of QueryTimeout.
Bugs: SOLR-5986
https://issues.apache.org/jira/browse/SOLR-5986
Repository: lucene
Description
-------
Timeout queries when they take too long to rewrite/enumerate over terms.
Diffs (updated)
-----
trunk/lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java
PRE-CREATION
trunk/lucene/core/src/java/org/apache/lucene/index/QueryTimeout.java
PRE-CREATION
trunk/lucene/core/src/java/org/apache/lucene/index/QueryTimeoutBase.java
PRE-CREATION
trunk/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java
PRE-CREATION
trunk/solr/core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java
1625349
trunk/solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
1625349
trunk/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
1625349
trunk/solr/core/src/java/org/apache/solr/search/SolrQueryTimeout.java
PRE-CREATION
trunk/solr/core/src/test/org/apache/solr/TestDistributedSearch.java 1625349
trunk/solr/core/src/test/org/apache/solr/TestGroupingSearch.java 1625349
trunk/solr/core/src/test/org/apache/solr/core/ExitableDirectoryReaderTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/25658/diff/
Testing
-------
Added Lucene/Solr tests. Tested a bit manually.
Thanks,
Anshum Gupta
