-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25658/
-----------------------------------------------------------
(Updated Sept. 17, 2014, 5:25 a.m.)
Review request for lucene.
Changes
-------
The QueryTimeoutBase is now an interface and SolrQueryTimeout and QueryTimeout
implement the mandatory shouldExit().
Also, the constructor and setter for the implementations now accept timeAllowed
in ms (as with TimeLimitingCollector) and set the internal timeoutAt value
themselves.
Bugs: SOLR-5986
https://issues.apache.org/jira/browse/SOLR-5986
Repository: lucene
Description
-------
Timeout queries when they take too long to rewrite/enumerate over terms.
Diffs (updated)
-----
trunk/lucene/core/src/java/org/apache/lucene/index/ExitableDirectoryReader.java
PRE-CREATION
trunk/lucene/core/src/java/org/apache/lucene/index/QueryTimeout.java
PRE-CREATION
trunk/lucene/core/src/java/org/apache/lucene/index/QueryTimeoutBase.java
PRE-CREATION
trunk/lucene/core/src/test/org/apache/lucene/index/TestExitableDirectoryReader.java
PRE-CREATION
trunk/solr/core/src/java/org/apache/solr/handler/MoreLikeThisHandler.java
1625349
trunk/solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
1625349
trunk/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
1625349
trunk/solr/core/src/java/org/apache/solr/search/SolrQueryTimeout.java
PRE-CREATION
trunk/solr/core/src/test/org/apache/solr/TestDistributedSearch.java 1625349
trunk/solr/core/src/test/org/apache/solr/TestGroupingSearch.java 1625349
trunk/solr/core/src/test/org/apache/solr/core/ExitableDirectoryReaderTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/25658/diff/
Testing
-------
Added Lucene/Solr tests. Tested a bit manually.
Thanks,
Anshum Gupta