[ 
https://issues.apache.org/jira/browse/LUCENE-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137028#comment-14137028
 ] 

Robert Muir commented on LUCENE-5958:
-------------------------------------

The thing is, the commit has already gone down, we cant throw any exception to 
the user here, because there is "no going back".

The only good solution i have, is similar to 'hitOOM' (maybe we can generalize 
that?) to hold exceptions like this, and deliver them in the future instead. In 
such a case (hitOOM=true or whatever we rename it to), we should definitely 
never delete any files for any reason. Leave it to the next writer.

> OOM or exceptions during checkpoint make IndexWriter have a bad day
> -------------------------------------------------------------------
>
>                 Key: LUCENE-5958
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5958
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> During finishCommit(), we run checkpoint after we wrote the commit to disk, 
> but if things go wrong here (e.g. IOError when IFD deletes a pending file, 
> OOM), then everything will go wrong (we won't even properly incref things, 
> and may end out deleting wrong files if the user calls rollback, leaving a 
> corrupt index).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to