[ 
https://issues.apache.org/jira/browse/LUCENE-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137506#comment-14137506
 ] 

Robert Muir commented on LUCENE-5958:
-------------------------------------

By the way, this patch still relays the exception in finishCOmmit (after we 
have actually committed!). It just prevents index corruption.

I think its confusing to relay the exception too? So i think we should suppress 
it in that case... otherwise the user probably thinks their commit failed when 
it succeeded...

> OOM or exceptions during checkpoint make IndexWriter have a bad day
> -------------------------------------------------------------------
>
>                 Key: LUCENE-5958
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5958
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5958.patch
>
>
> During finishCommit(), we run checkpoint after we wrote the commit to disk, 
> but if things go wrong here (e.g. IOError when IFD deletes a pending file, 
> OOM), then everything will go wrong (we won't even properly incref things, 
> and may end out deleting wrong files if the user calls rollback, leaving a 
> corrupt index).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to