[
https://issues.apache.org/jira/browse/LUCENE-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-5992:
--------------------------------
Attachment: LUCENE-5992.patch
Simpler iteration. Since major/minor/bugfix etc are 'public' in Version (its
clearly a thin wrapper around these and they are not an internal detail), then
we don't need the toArray method.
Again, the important stuff is this: if we want to do something crazy like write
massive numbers, or write alpha/beta, just make a new SIFormat. We don't need
to future proof things inside the codec API.
> Version should not be encoded as a String in the index
> ------------------------------------------------------
>
> Key: LUCENE-5992
> URL: https://issues.apache.org/jira/browse/LUCENE-5992
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-5992.patch, LUCENE-5992.patch, LUCENE-5992.patch,
> LUCENE-5992.patch
>
>
> The version is really "just" 3 (maybe 4) ints under-the-hood, but today we
> write it as a String which then requires spooky string tokenization/parsing
> when we open the index. I think it should be encoded directly as ints.
> In LUCENE-5952 I had tried to make this change, but it was controversial, and
> got booted.
> Then in LUCENE-5969, I tried again, but that issue has morphed (nicely!) into
> fixing all sorts of things *except* these three ints.
> Maybe 3rd time's a charm ;)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
