[ 
https://issues.apache.org/jira/browse/LUCENE-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-5992:
--------------------------------
    Attachment: LUCENE-5992_tests.patch

Thanks Mike (i am intermittent), i just wanted to add tests and so on too.

I also hate that we pass FIS to SIWriter (it just made tests hard and seems 
bogus??? so i removed that too).

see patch


> Version should not be encoded as a String in the index
> ------------------------------------------------------
>
>                 Key: LUCENE-5992
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5992
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0, Trunk
>
>         Attachments: LUCENE-5992.patch, LUCENE-5992.patch, LUCENE-5992.patch, 
> LUCENE-5992.patch, LUCENE-5992_tests.patch
>
>
> The version is really "just" 3 (maybe 4) ints under-the-hood, but today we 
> write it as a String which then requires spooky string tokenization/parsing 
> when we open the index.  I think it should be encoded directly as ints.
> In LUCENE-5952 I had tried to make this change, but it was controversial, and 
> got booted.
> Then in LUCENE-5969, I tried again, but that issue has morphed (nicely!) into 
> fixing all sorts of things *except* these three ints.
> Maybe 3rd time's a charm ;)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to