[
https://issues.apache.org/jira/browse/LUCENE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14164377#comment-14164377
]
Robert Muir commented on LUCENE-6000:
-------------------------------------
Looks good. Can you delete the actual interface file? I don't see it nuked in
the patch. :)
I think this is ok to commit, personally i would go just a step further and
instead remove StandardTokenizerImpl and so on too. without the interface, this
abstraction isn't needed, the StandardTokenizer.jflex can just generate
StandardTokenizer.java and StandardTokenizer40.jflex ->
StandardTokenizer40.java and so on.
> Remove StandardTokenizerInterface
> ---------------------------------
>
> Key: LUCENE-6000
> URL: https://issues.apache.org/jira/browse/LUCENE-6000
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Ryan Ernst
> Attachments: LUCENE-6000.patch
>
>
> This interface existed for backcompat, so that each impl had at least some
> common minimal interface, and could be used by StandardTokenizer. However,
> in LUCENE-5999 backcompat for standard tokenizer was implemented using
> separate named classes. We should remove this interface, as it no longer
> serves a purpose.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
