[
https://issues.apache.org/jira/browse/LUCENE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191680#comment-14191680
]
Uwe Schindler commented on LUCENE-6039:
---------------------------------------
+1
Null is always bad. Its horrible to use null for empty collections instead of
Collections.emptyList() or like that. To me the other worst thing is the "null"
Scorer or "null" DocIdSets.... To me a query hitting no docs, should return an
Empty Scorer implementation.
> Add IndexOptions.NO and DocValuesType.NO, instead of null
> ---------------------------------------------------------
>
> Key: LUCENE-6039
> URL: https://issues.apache.org/jira/browse/LUCENE-6039
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-6039.patch
>
>
> Idea from Simon: it seems dangerous for IndexOptions and DocValuesType
> via Indexable/FieldType and FieldInfo that we use null to mean it's
> not indexed or has no doc values.
> We should instead have an explicit choice (IndexOptions.NO,
> DocValuesType.NO) in the enum?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
