[
https://issues.apache.org/jira/browse/LUCENE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191702#comment-14191702
]
Robert Muir commented on LUCENE-6039:
-------------------------------------
+1 (i would commit it soon, so it doesnt go out of date).
When reviewing usages, i noticed some cases like this (SegmentReader):
{code}
if (fieldInfo.getDocValuesType() == null) {
{code}
We should open a followup issue to decide what to do about helper methods of
hasDocValues()/isIndexed()... either cutover consistently or remove the helpers?
> Add IndexOptions.NO and DocValuesType.NO, instead of null
> ---------------------------------------------------------
>
> Key: LUCENE-6039
> URL: https://issues.apache.org/jira/browse/LUCENE-6039
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-6039.patch
>
>
> Idea from Simon: it seems dangerous for IndexOptions and DocValuesType
> via Indexable/FieldType and FieldInfo that we use null to mean it's
> not indexed or has no doc values.
> We should instead have an explicit choice (IndexOptions.NO,
> DocValuesType.NO) in the enum?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
