----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28393/#review62783 -----------------------------------------------------------
trunk/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java <https://reviews.apache.org/r/28393/#comment104896> Should use default constants. trunk/solr/server/etc/jetty.xml <https://reviews.apache.org/r/28393/#comment104897> Should mention threadPoolSweeperMaxIdleTime goes in solr.xml. - Mark Miller On Nov. 24, 2014, 3:42 p.m., Mark Miller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28393/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 3:42 p.m.) > > > Review request for lucene. > > > Repository: lucene > > > Description > ------- > > https://issues.apache.org/jira/browse/SOLR-4509 > > > Diffs > ----- > > trunk/solr/core/src/java/org/apache/solr/core/ConfigSolr.java 1641405 > trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java 1641405 > trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java 1641405 > trunk/solr/core/src/java/org/apache/solr/core/CoreContainer.java 1641405 > trunk/solr/core/src/java/org/apache/solr/core/PluginInfo.java 1641405 > > trunk/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java > 1641405 > trunk/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java > 1641405 > > trunk/solr/core/src/java/org/apache/solr/util/IdleConnectionMonitorRunnable.java > PRE-CREATION > trunk/solr/core/src/test/org/apache/solr/cloud/OverseerTest.java 1641405 > > trunk/solr/core/src/test/org/apache/solr/cloud/TestLeaderElectionZkExpiry.java > 1641405 > trunk/solr/core/src/test/org/apache/solr/cloud/TestZkChroot.java 1641405 > trunk/solr/core/src/test/org/apache/solr/cloud/ZkControllerTest.java > 1641405 > trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java > 1641405 > > trunk/solr/core/src/test/org/apache/solr/core/TestImplicitCoreProperties.java > 1641405 > trunk/solr/server/etc/jetty.xml 1641405 > > trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java > 1641405 > > Diff: https://reviews.apache.org/r/28393/diff/ > > > Testing > ------- > > > Thanks, > > Mark Miller > >
