> On Nov. 25, 2014, 12:55 a.m., Gregory Chanan wrote: > > trunk/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java, > > line 185 > > <https://reviews.apache.org/r/28393/diff/1/?file=774311#file774311line185> > > > > So we don't do anything if we don't use the default client? This seems > > like a better fit for the HttpClientUtil. > > Mark Miller wrote: > Yeah, its up to the creator of the http client to decide what params to > pass and whether or not they want to use the IdleConnectionMonitorRunnable. > Good flag though, we should also do this for the http client used by peer > sync. I was going to search for all our uses, but I'm mainly concerned about > main query and update paths. > > Mark Miller wrote: > Oh wait, the peer sync client doesn't need it - it's just using the > update httpclient already.
Okay, looking some more, I can see why you might want to make this part of createHttpClient in HttpClientUtil - it would present a problem though - the sweeper needs to be user configurable, it makes most sense for that to go in solr.xml, but HttpClientUtil is all static. Only system property config would really work well. I suppose we could consider this an advanced use case and leave it at that...we would also probably have to return something like a SolrHttpClient instead to manage the executor lifecycle. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28393/#review62902 ----------------------------------------------------------- On Nov. 24, 2014, 3:42 p.m., Mark Miller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28393/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2014, 3:42 p.m.) > > > Review request for lucene. > > > Repository: lucene > > > Description > ------- > > https://issues.apache.org/jira/browse/SOLR-4509 > > > Diffs > ----- > > trunk/solr/core/src/java/org/apache/solr/core/ConfigSolr.java 1641405 > trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java 1641405 > trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java 1641405 > trunk/solr/core/src/java/org/apache/solr/core/CoreContainer.java 1641405 > trunk/solr/core/src/java/org/apache/solr/core/PluginInfo.java 1641405 > > trunk/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java > 1641405 > trunk/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java > 1641405 > > trunk/solr/core/src/java/org/apache/solr/util/IdleConnectionMonitorRunnable.java > PRE-CREATION > trunk/solr/core/src/test/org/apache/solr/cloud/OverseerTest.java 1641405 > > trunk/solr/core/src/test/org/apache/solr/cloud/TestLeaderElectionZkExpiry.java > 1641405 > trunk/solr/core/src/test/org/apache/solr/cloud/TestZkChroot.java 1641405 > trunk/solr/core/src/test/org/apache/solr/cloud/ZkControllerTest.java > 1641405 > trunk/solr/core/src/test/org/apache/solr/core/TestCoreDiscovery.java > 1641405 > > trunk/solr/core/src/test/org/apache/solr/core/TestImplicitCoreProperties.java > 1641405 > trunk/solr/server/etc/jetty.xml 1641405 > > trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java > 1641405 > > Diff: https://reviews.apache.org/r/28393/diff/ > > > Testing > ------- > > > Thanks, > > Mark Miller > >
