[ 
https://issues.apache.org/jira/browse/SOLR-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14257248#comment-14257248
 ] 

Ishan Chattopadhyaya commented on SOLR-6797:
--------------------------------------------

Thanks David!

> What was the template of this code (in other words, what did you copy-paste 
> to get started)?
I used the TestManagedSchema's testAddFieldThenReload() template.

> schema-bm25.xml etc. looks very misplaced; please strip it down.
Cool, I'll have a look!

> BTW, did you notice the existing spatial tests (particularly the new since 
> Solr 4 ones)? 
> They aren't particularly obvious but they are TestSolr4Spatial and 
> TestSolr4Spatial2. 
I did have a look, and changed the schema used in that test to use 
distanceUnits instead of units. :-) However, I verified that those tests pass 
even with older units parameter, so backward compatibility is intact.

> Add score=degrees|kilometers|miles for AbstractSpatialFieldType
> ---------------------------------------------------------------
>
>                 Key: SOLR-6797
>                 URL: https://issues.apache.org/jira/browse/SOLR-6797
>             Project: Solr
>          Issue Type: Improvement
>          Components: spatial
>            Reporter: David Smiley
>         Attachments: SOLR-6797.patch, SOLR-6797.patch, SOLR-6797.patch
>
>
> Annoyingly, the units="degrees" attribute is required for fields extending 
> AbstractSpatialFieldType (e.g. RPT, BBox).  And it doesn't really have any 
> effect.  I propose the following:
> * Simply drop the attribute; ignore it if someone sets it to "degrees" (for 
> back-compat).
> * When using score="distance", or score=area or area2D (as seen in BBoxField) 
> then use kilometers if geo=true, otherwise degrees.
> * Add support for score=degrees|kilometers|miles|degrees



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to