[ 
https://issues.apache.org/jira/browse/SOLR-6797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262924#comment-14262924
 ] 

David Smiley commented on SOLR-6797:
------------------------------------

The remaining part we forgot about was geodist, as mentioned in the Review 
Board minutes ago. That's a blocker.

BTW this is the CHANGES.txt additions I wrote up:

Upgrading:
{noformat}
* Spatial fields originating from Solr 4 (e.g. 
SpatialRecursivePrefixTreeFieldType, BBoxField)
  have the 'units' attribute deprecated, now replaced with 'distanceUnits'.  If 
you change it to
  a unit other than 'degrees' (or if you don't specify it, which will default 
to kilometers if
  geo=true), then be sure to update maxDistErr as it's in those units.  If you 
keep units=degrees
  then it should be backwards compatible but you'll get a deprecation warning 
on startup.  See
  SOLR-6797.
{noformat}

New Features:
{noformat}
* SOLR-6797: Spatial fields that used to require units=degrees like
  SpatialRecursivePrefixTreeFieldType (RPT) now don't; it's deprecated.  It's 
replaced with a
  distanceUnits attribute allowing degrees|kilometers|miles. It affects the 
result of the
  score=distance|area|area2d mode of queries using this field which will now 
use these units,
  as well as maxDistErr, distErr and the 'd' parameter referenced by geofilt 
and geodist.  score
  now supports kilometers|miles|degrees to choose at query time. It does NOT 
affect distances
  embedded in WKT strings like BUFFER(POINT(200 10),0.2))
  (Ishan Chattopadhyaya, David Smiley)
{noformat}

> Add score=degrees|kilometers|miles for AbstractSpatialFieldType
> ---------------------------------------------------------------
>
>                 Key: SOLR-6797
>                 URL: https://issues.apache.org/jira/browse/SOLR-6797
>             Project: Solr
>          Issue Type: Improvement
>          Components: spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 5.0, Trunk
>
>         Attachments: SOLR-6797.patch, SOLR-6797.patch, SOLR-6797.patch, 
> SOLR-6797.patch, SOLR-6797.patch, SOLR-6797.patch
>
>
> Annoyingly, the units="degrees" attribute is required for fields extending 
> AbstractSpatialFieldType (e.g. RPT, BBox).  And it doesn't really have any 
> effect.  I propose the following:
> * Simply drop the attribute; ignore it if someone sets it to "degrees" (for 
> back-compat).
> * When using score="distance", or score=area or area2D (as seen in BBoxField) 
> then use kilometers if geo=true, otherwise degrees.
> * Add support for score=degrees|kilometers|miles|degrees



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to