[ 
https://issues.apache.org/jira/browse/LUCENE-4746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14262257#comment-14262257
 ] 

Uwe Schindler commented on LUCENE-4746:
---------------------------------------

bq. What is the rant about unwrapping? There is no unwrapping in my patch. I 
have not and will not touch any unwrap method here on this issue. I didn't even 
know it existed.

Was not about your patch. I will open another issue obout this horrible unwrap 
method. Its a bad sign, does not affect this issue. I was just looking for a 
solutions for the instanceof shit.

> Create a move method in Directory.
> ----------------------------------
>
>                 Key: LUCENE-4746
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4746
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: 4.9, Trunk
>
>         Attachments: LUCENE-4746.patch, LUCENE-4746.patch
>
>
> I'd like to make a move method for directory.
> We already have a move for Solr in DirectoryFactory, but it seems it belongs 
> at the directory level really.
> The default impl can do a copy and delete, but most implementations will be 
> able to optimize to a rename.
> Besides the move we do for Solr (to move a replicated index into place), it 
> would also be useful for another feature I'd like to add - the ability to 
> merge an index with moves rather than copies. In some cases, you don't 
> need/want to copy all the files and could just rename/move them. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to