[ 
https://issues.apache.org/jira/browse/SOLR-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276158#comment-14276158
 ] 

Varun Thacker commented on SOLR-6920:
-------------------------------------

Hi [[email protected]],

Thanks for the review!

bq. We should not need the back compat < 5.0 code AFAICT though.
>From what I understand an index built pre LUCENE-2446 would not have the 
>checksum , so {{CodecUtil.retrieveChecksum(in)}} would throw an error as the 
>validation would fail. I guess the check should be 4_8 and not 5_0 though.

> During replication use checksums to verify if files are the same
> ----------------------------------------------------------------
>
>                 Key: SOLR-6920
>                 URL: https://issues.apache.org/jira/browse/SOLR-6920
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java)
>            Reporter: Varun Thacker
>         Attachments: SOLR-6920.patch, SOLR-6920.patch
>
>
> Currently we check if an index file on the master and slave is the same by 
> checking if it's name and file length match. 
> With LUCENE-2446 we now have a checksums for each index file in the segment. 
> We should leverage this to verify if two files are the same.
> Places like SnapPuller.isIndexStale and SnapPuller.downloadIndexFiles should 
> check against the checksum also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to