[ 
https://issues.apache.org/jira/browse/SOLR-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309538#comment-14309538
 ] 

Mark Miller commented on SOLR-6920:
-----------------------------------

bq. In your patch if the file fails to retrieve a checksum...

Feel free to put up a follow on patch - this one is just a first draft. I'll be 
taking another pass when I get a chance as well.

bq. I think you have an extra file from HdfsTestUtil in the patch.

No, that's fixes an error I see in the test that shalin mentions in SOLR-6640 
and led me back to this issue.

> During replication use checksums to verify if files are the same
> ----------------------------------------------------------------
>
>                 Key: SOLR-6920
>                 URL: https://issues.apache.org/jira/browse/SOLR-6920
>             Project: Solr
>          Issue Type: Bug
>          Components: replication (java)
>            Reporter: Varun Thacker
>            Assignee: Mark Miller
>            Priority: Critical
>         Attachments: SOLR-6920.patch, SOLR-6920.patch, SOLR-6920.patch, 
> SOLR-6920.patch
>
>
> Currently we check if an index file on the master and slave is the same by 
> checking if it's name and file length match. 
> With LUCENE-2446 we now have a checksums for each index file in the segment. 
> We should leverage this to verify if two files are the same.
> Places like SnapPuller.isIndexStale and SnapPuller.downloadIndexFiles should 
> check against the checksum also.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to