[
https://issues.apache.org/jira/browse/SOLR-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284029#comment-14284029
]
Hoss Man commented on SOLR-6976:
--------------------------------
bq. SimpleFacets.rangeCount() - this seems to be used elsewhere in places that
it doesn't obviously make sense to use the suggested replacement classes.
There are 2 rangeCount methods, the one that is deprecated is...
{code}
/**
* @deprecated Use rangeCount(SchemaField,String,String,boolean,boolean)
which is more generalized
*/
@Deprecated
protected int rangeCount(SchemaField sf, Date low, Date high,
boolean iLow, boolean iHigh) throws IOException {
{code}
...the only place _that_ version of rangeCount is used is inside of
SimpleFacets.getFacetDateCounts -- which is also deprecated.
removing SimpleFacets.getFacetDateCounts is a bigger undertaking, because it
conceptually means removing all of the "facet.date" functionality (not just
internal APIs)
I'm -0 on making the call to (finally) remove all end user support for
facet.date this late in the process for 5.0, but what would probably make sense
is to go ahead and rename & make private the deprecated rangeCount method.
> Remove all methods and classes deprecated in 4.x from trunk and 5.x
> -------------------------------------------------------------------
>
> Key: SOLR-6976
> URL: https://issues.apache.org/jira/browse/SOLR-6976
> Project: Solr
> Issue Type: Task
> Reporter: Alan Woodward
> Priority: Blocker
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6976.patch, SOLR-6976.patch, SOLR-sharkeys.patch
>
>
> We have a bunch of methods, classes, enums, etc which are marked as
> deprecated in Solr code in the 4.x branch. Some of them have been marked as
> such since the 1.4 release. Before we get 5.0 out, these should all be
> removed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
