[
https://issues.apache.org/jira/browse/LUCENE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290788#comment-14290788
]
Ramkumar Aiyengar commented on LUCENE-6188:
-------------------------------------------
Thanks for the fix [~mikemccand], this certainly stops the related issue from
being blocked (and is now committed). But can someone comment still on if this
verification has any use? As I mention, this check is already done by
{{checkJavadocLinks.py}} which runs on all the files being covered by this
script (and more), so this code can still be removed to make precommits
slightly faster, unless I am missing something here..
> Remove HTML verification from checkJavaDocs.py
> ----------------------------------------------
>
> Key: LUCENE-6188
> URL: https://issues.apache.org/jira/browse/LUCENE-6188
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/javadocs
> Reporter: Ramkumar Aiyengar
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 5.0, Trunk, 5.1
>
> Attachments: LUCENE-6188.patch, LUCENE-6188.patch
>
>
> Currently, the broken HTML verification in {{checkJavaDocs.py}} has issues in
> some cases (see SOLR-6902).
> On looking further to fix it with the {{html.parser}} package instead,
> noticed that there is broken HTML verification already present (using
> {{html.parser}}!)in {{checkJavadocLinks.py}} anyway which takes care of
> validation, and probably {{jTidy}} does it as well, going by the output
> (haven't verified it).
> Given this, the validation in {{checkJavaDocs.py}} doesn't seem to add any
> further value, so here's a patch to just nuke it instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
