[
https://issues.apache.org/jira/browse/LUCENE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290806#comment-14290806
]
Erick Erickson commented on LUCENE-6188:
----------------------------------------
[~anshum]
bq: Can you confirm?
[~mikemccand] committed it, but I just looked at trunk, 5.x and 5.0 and the
change appears to be in all three.
Shouldn't matter too much anyway, the problem was only tripped by code that is
_not_ (and will not be) in 5.0, so as long as it's in 5x and trunk we're good.
The patches above are not what Mike checked in, see
5.0: r1654012
5.x: r1654008
trunk: r1654004
> Remove HTML verification from checkJavaDocs.py
> ----------------------------------------------
>
> Key: LUCENE-6188
> URL: https://issues.apache.org/jira/browse/LUCENE-6188
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/javadocs
> Reporter: Ramkumar Aiyengar
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 5.0, Trunk, 5.1
>
> Attachments: LUCENE-6188.patch, LUCENE-6188.patch
>
>
> Currently, the broken HTML verification in {{checkJavaDocs.py}} has issues in
> some cases (see SOLR-6902).
> On looking further to fix it with the {{html.parser}} package instead,
> noticed that there is broken HTML verification already present (using
> {{html.parser}}!)in {{checkJavadocLinks.py}} anyway which takes care of
> validation, and probably {{jTidy}} does it as well, going by the output
> (haven't verified it).
> Given this, the validation in {{checkJavaDocs.py}} doesn't seem to add any
> further value, so here's a patch to just nuke it instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
