[ 
https://issues.apache.org/jira/browse/LUCENE-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337445#comment-14337445
 ] 

Michael McCandless commented on LUCENE-6297:
--------------------------------------------

Actually I think this is a non-issue: if you cast a too-large double to long in 
java, it casts to Long.MAX_VALUE: 
http://docs.oracle.com/javase/specs/jls/se7/html/jls-5.html#jls-5.1.3

I will add a test case and a comment about this ...

> LogByteSizeMergePolicy maxMergeSizeForForcedMerge default is negative
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-6297
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6297
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.10.3, 5.0
>            Reporter: Toke Eskildsen
>            Priority: Blocker
>             Fix For: 4.10.4, Trunk
>
>         Attachments: SOLR-7163.patch
>
>
> The default value for {{maxMergeSizeForForcedMerge}} in the class 
> {{LogByteSizeMergePolicy}} is {{Long.MAX_VALUE*1024*1024}} which overflows 
> and becomes -1048576.
> As far as I can see this results in forced merges always failing to merge, 
> but frankly this is so far from my area of interest that I will not take the 
> time to create a proper unit test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to