[ 
https://issues.apache.org/jira/browse/LUCENE-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338036#comment-14338036
 ] 

Toke Eskildsen commented on LUCENE-6297:
----------------------------------------

(My previous comment was lost? Strange...)

Anyway, while I did run a code snippet to verify my findings, I made a mistake 
and wrote something to the effect of {{double DEFAULT=Long.MAX_VALUE ; int 
MAX=(long)DEFAULT*1024*1024}} instead of {{double DEFAULT=Long.MAX_VALUE ; int 
MAX=(long)(DEFAULT*1024*1024)}}. The missing parantheses meant that the cast to 
long was done on {{DEFAULT}} instead of the full expression.

False alarm. I apologize for the inconvenience.


> LogByteSizeMergePolicy maxMergeSizeForForcedMerge default is negative
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-6297
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6297
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.10.3, 5.0
>            Reporter: Toke Eskildsen
>            Priority: Minor
>             Fix For: Trunk, 5.1
>
>         Attachments: SOLR-7163.patch
>
>
> The default value for {{maxMergeSizeForForcedMerge}} in the class 
> {{LogByteSizeMergePolicy}} is {{Long.MAX_VALUE*1024*1024}} which overflows 
> and becomes -1048576.
> As far as I can see this results in forced merges always failing to merge, 
> but frankly this is so far from my area of interest that I will not take the 
> time to create a proper unit test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to