[ 
https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338743#comment-14338743
 ] 

Mark Miller commented on SOLR-7130:
-----------------------------------

bq. +      if(col !=null) {

These if's should have a space after them. Please install the correct lucene / 
solr code formating rules into your IDE.

> Make stale state notification work without failing the requests
> ---------------------------------------------------------------
>
>                 Key: SOLR-7130
>                 URL: https://issues.apache.org/jira/browse/SOLR-7130
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java, SolrCloud, SolrJ
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Noble Paul
>             Fix For: Trunk, 5.1
>
>         Attachments: SOLR-7130.patch, SOLR-7130.patch
>
>
> I wasn't sure whether to label this a bug or an improvement.
> For collections with stateFormat=2, we now fail requests (because of stale 
> state) which we didn't previously. The client having stale cached cluster 
> state is not a sufficient reason to fail and retry the entire request because 
> in most of such cases, the node receiving the request is still perfectly 
> capable of returning a valid response (either from local replicas or remote 
> ones).
> We should find a better way to notify clients that they have stale state. 
> Perhaps we can modify the response and add a "routing" section instead of 
> outright exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to