FWIW, in IntelliJ the auto-format stuff has an "only vcs changed text"
option that I find quite useful, cmd-alt-L on a file-by-file basis and
I'm done.

There's also an officially approved style file that _might_ installed
when you execute the 'ant idea' task, but I'm not certain whether
that's
happening or I just set up my IDE with the style a while ago for all projects...


On Thu, Feb 26, 2015 at 9:34 AM, Mark Miller (JIRA) <[email protected]> wrote:
>
>     [ 
> https://issues.apache.org/jira/browse/SOLR-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338749#comment-14338749
>  ]
>
> Mark Miller commented on SOLR-7130:
> -----------------------------------
>
> bq. if(col !=null) {
>
> This one in particular needs a space before null as well. It's easier to let 
> your IDE do the work of proper formatting rather than introducing a lot of 
> sloppy formatting as has been happening. We have a code standard - it's not 
> the law, but everyone should at least make a half hearted attempt at 
> following it.
>
>> Make stale state notification work without failing the requests
>> ---------------------------------------------------------------
>>
>>                 Key: SOLR-7130
>>                 URL: https://issues.apache.org/jira/browse/SOLR-7130
>>             Project: Solr
>>          Issue Type: Improvement
>>          Components: clients - java, SolrCloud, SolrJ
>>            Reporter: Shalin Shekhar Mangar
>>            Assignee: Noble Paul
>>             Fix For: Trunk, 5.1
>>
>>         Attachments: SOLR-7130.patch, SOLR-7130.patch
>>
>>
>> I wasn't sure whether to label this a bug or an improvement.
>> For collections with stateFormat=2, we now fail requests (because of stale 
>> state) which we didn't previously. The client having stale cached cluster 
>> state is not a sufficient reason to fail and retry the entire request 
>> because in most of such cases, the node receiving the request is still 
>> perfectly capable of returning a valid response (either from local replicas 
>> or remote ones).
>> We should find a better way to notify clients that they have stale state. 
>> Perhaps we can modify the response and add a "routing" section instead of 
>> outright exception.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to