[ 
https://issues.apache.org/jira/browse/LUCENE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342231#comment-14342231
 ] 

Robert Muir commented on LUCENE-6317:
-------------------------------------

I think we should deprecate the current readStringStringMap/readStringSet and 
define new ones that:
* write the size as vint (int is stupid here)
* always return immutable maps/sets. this just matches how lucene works.


> Fix readStringStringMap api
> ---------------------------
>
>                 Key: LUCENE-6317
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6317
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Robert Muir
>             Fix For: Trunk, 5.1
>
>
> Currently this api is not very efficient, and always returns a mutable map.
> Can we change it to allow immutability? its sad we don't return 
> Collections.emptyMap so its the same instance for all empty cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to