[ 
https://issues.apache.org/jira/browse/LUCENE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14342236#comment-14342236
 ] 

Robert Muir commented on LUCENE-6317:
-------------------------------------

This means bumping formats of .si/.fis/segments_N, but I think its the right 
thing to do. Once a segment is read, the structures encoded in these maps 
should not be modified by anyone.

Alternatively, we could keep the format the same, but then we leave the bloated 
4 byte size, we change behavior in a scary way of an existing method, etc. To 
me this is not better, only easier.

> Fix readStringStringMap api
> ---------------------------
>
>                 Key: LUCENE-6317
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6317
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Robert Muir
>             Fix For: Trunk, 5.1
>
>
> Currently this api is not very efficient, and always returns a mutable map.
> Can we change it to allow immutability? its sad we don't return 
> Collections.emptyMap so its the same instance for all empty cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to