[ 
https://issues.apache.org/jira/browse/SOLR-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352228#comment-14352228
 ] 

Alan Woodward commented on SOLR-7203:
-------------------------------------

bq. I'd have to -1 anything else since it breaks the system 

Fussy, fussy.

The patch as it stands just moves the retry logic to the right place, and 
leaves the default number of retries as 0.  I think that should be OK to go in?

> NoHttpResponseException handling in HttpSolrClient is wrong
> -----------------------------------------------------------
>
>                 Key: SOLR-7203
>                 URL: https://issues.apache.org/jira/browse/SOLR-7203
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>         Attachments: SOLR-7203.patch, SOLR-7203.patch
>
>
> We've got logic in HttpSolrClient to catch NoHttpResponseException and retry. 
>  However, this logic appears to be in the wrong place - it's in the 
> createMethod function, which doesn't actually execute any http requests at 
> all.  It ought to be in executeMethod.
> Fixing this might help sort out the persistent Jenkins failures as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to