[
https://issues.apache.org/jira/browse/SOLR-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353667#comment-14353667
]
Greg Solovyev commented on SOLR-7203:
-------------------------------------
Shawn, if you look closely at what is happening in the while loop, you will see
that the request object is being created in it, but is not actually being sent.
The request is being sent in HttpSolrClient::executeMethod and maxRetries is
being used in createMethod. FWIF, there isn't anything in that while look that
can thrown NoHttpResponseException :)
> NoHttpResponseException handling in HttpSolrClient is wrong
> -----------------------------------------------------------
>
> Key: SOLR-7203
> URL: https://issues.apache.org/jira/browse/SOLR-7203
> Project: Solr
> Issue Type: Bug
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Attachments: SOLR-7203.patch, SOLR-7203.patch, SOLR-7203.patch
>
>
> We've got logic in HttpSolrClient to catch NoHttpResponseException and retry.
> However, this logic appears to be in the wrong place - it's in the
> createMethod function, which doesn't actually execute any http requests at
> all. It ought to be in executeMethod.
> Fixing this might help sort out the persistent Jenkins failures as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
