[
https://issues.apache.org/jira/browse/SOLR-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352302#comment-14352302
]
Greg Solovyev commented on SOLR-6724:
-------------------------------------
This problem pops up in our environment fairly frequently when Solr server and
client app run on the same machine, which is why I started looking into this.
After reading the thread on https://issues.apache.org/jira/browse/SOLR-7203
think that the patch I submitted is rather useless. IMHO, it makes more sense
to let the parent application handle all IOExceptions thrown by HttpClient when
HttpSolrServer uses an external instance of HttpClient. Also, when
HttpSolrServer is using internal HttpClient, it shouldn't blindly retry the
request, but should try to clean up dead connections first and perhaps use a
timeout before retrying.
> HttpServer maxRetries attributes seems like not being used as expected
> ----------------------------------------------------------------------
>
> Key: SOLR-6724
> URL: https://issues.apache.org/jira/browse/SOLR-6724
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.10.2
> Environment: OS X 10.9.5
> Java 1.7.0_60
> Reporter: Márcio Furlani Carmona
> Priority: Minor
> Attachments: SOLR-6724.patch
>
>
> Looks like maxRetries is being misused in the
> org.apache.solr.client.solrj.impl.HttpSolrServer.createMethod(SolrRequest)
> instead of being used in the executeMethod(HttpRequestBase,ResponseParser).
> In the current implementation the maxRetries is used in a loop that only
> instantiates the HttpRequestBase but it doesn't effectively make any HTTP
> request. Also the retries are made even in a successful instantiation of the
> HttpRequestBase as there's no break too.
> I notice there's also a catch for NoHttpResponseException but as no HTTP
> request is made I guess it will never happen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
