[ 
https://issues.apache.org/jira/browse/SOLR-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14352372#comment-14352372
 ] 

Mark Miller commented on SOLR-6724:
-----------------------------------

bq. This problem pops up in our environment fairly frequently when Solr server 
and client app run on the same machine

That sounds unusual - I wonder why / what makes this happen more frequently 
with your setup. Normally, with the current code, it's quite hard to hit under 
normal circumstances, because the stale connection check will hit it and retry 
(stale connection check happens before the request, and so it's safe). There is 
a race with the stale connection check, so it's not perfect, but I've supported 
a lot of SolrCloud setups, and I've yet to see this happen very frequently on a 
normally operating system. Usually, a reset connection is the more common thing 
to fall through that race (I've seen HttpNoResponseException, but like 1/20th 
as much as connection reset).

> HttpServer maxRetries attributes seems like not being used as expected
> ----------------------------------------------------------------------
>
>                 Key: SOLR-6724
>                 URL: https://issues.apache.org/jira/browse/SOLR-6724
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 4.10.2
>         Environment: OS X 10.9.5
> Java 1.7.0_60
>            Reporter: Márcio Furlani Carmona
>            Priority: Minor
>         Attachments: SOLR-6724.patch
>
>
> Looks like maxRetries is being misused in the 
> org.apache.solr.client.solrj.impl.HttpSolrServer.createMethod(SolrRequest) 
> instead of being used in the executeMethod(HttpRequestBase,ResponseParser).
> In the current implementation the maxRetries is used in a loop that only 
> instantiates the HttpRequestBase but it doesn't effectively make any HTTP 
> request. Also the retries are made even in a successful instantiation  of the 
> HttpRequestBase as there's no break too.
> I notice there's also a catch for NoHttpResponseException but as no HTTP 
> request is made I guess it will never happen.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to