[ 
https://issues.apache.org/jira/browse/SOLR-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487703#comment-14487703
 ] 

Shalin Shekhar Mangar commented on SOLR-7371:
---------------------------------------------

Thank you for fixing the base calculations, Yonik.

One question for my own understanding -- the shallowSizeOfInstance method will 
add an object reference size for any array instance but then we add an array 
header size which includes an object reference size too. So we are adding an 
extra object reference size, right? Though that's a small over-calculation 
compared to the size of objects we will be measuring so it's not a big deal.

> Make DocSet Accountable
> -----------------------
>
>                 Key: SOLR-7371
>                 URL: https://issues.apache.org/jira/browse/SOLR-7371
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Yonik Seeley
>             Fix For: Trunk, 5.2
>
>         Attachments: SOLR-7371.patch, SOLR-7371.patch
>
>
> Make DocSet implement Accountable so that we can correctly estimate memory 
> usage.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to