[
https://issues.apache.org/jira/browse/SOLR-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487562#comment-14487562
]
Shalin Shekhar Mangar commented on SOLR-7371:
---------------------------------------------
I fixed the NPE. Sorry for the noise guys.
bq. I don't think we should pre-calculate the ram size (thus increasing the
size of smaller DocSet objects
These are immutable objects, right? The ram usage will be checked on each 'put'
of a cache (see SOLR-7372) so I think it makes sense to just pre-calculate? In
fact, I am surprised that FixedBitSet doesn't pre-calculate the ram usage.
> Make DocSet Accountable
> -----------------------
>
> Key: SOLR-7371
> URL: https://issues.apache.org/jira/browse/SOLR-7371
> Project: Solr
> Issue Type: Improvement
> Reporter: Shalin Shekhar Mangar
> Assignee: Yonik Seeley
> Fix For: Trunk, 5.2
>
> Attachments: SOLR-7371.patch
>
>
> Make DocSet implement Accountable so that we can correctly estimate memory
> usage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
