[
https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506537#comment-14506537
]
Anshum Gupta commented on SOLR-7408:
------------------------------------
One last thing and it's a +1 from my end.
Can you also remove the check for {{collection == null}} in the line below?That
check would never be false due to the assert right above.
It's not something that you changed but I think it'd be good to just clean that
up.
{code}
public void unregister(String coreName, CoreDescriptor cd) throws
InterruptedException, KeeperException {
final String coreNodeName = cd.getCloudDescriptor().getCoreNodeName();
final String collection = cd.getCloudDescriptor().getCollectionName();
assert collection != null;
if (collection == null || collection.trim().length() == 0) {
log.error("No collection was specified.");
{code}
> Let SolrCore be the only thing which registers/unregisters a config directory
> listener
> --------------------------------------------------------------------------------------
>
> Key: SOLR-7408
> URL: https://issues.apache.org/jira/browse/SOLR-7408
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: SOLR-7408.patch, SOLR-7408.patch, SOLR-7408.patch,
> SOLR-7408.patch
>
>
> As reported here: http://markmail.org/message/ynkm2axkdprppgef, there is a
> race condition which results in an exception when creating multiple
> collections over the same config set. I was able to reproduce it in a test,
> although I am only able to reproduce if I put break points and manually
> simulate the problematic context switches.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
