[
https://issues.apache.org/jira/browse/SOLR-7408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506550#comment-14506550
]
Shai Erera commented on SOLR-7408:
----------------------------------
I think that removing that check is dangerous since someone who doesn't run w/
assertions enabled (i.e. in production) will hit an NPE, rather than see this
error message. I would rather remove the assert and change the code as follows:
{code}
if (collection == null || collection.trim().length() == 0) {
log.error("No collection was specified.");
assert false : "No collection was specified: [" + collection + "]";
return;
}
{code}
About removing the test, I understand it seems like a waste of time to run a 30
seconds test that now seems to be fixed. But if we remove it, and a bug creeps
back into the code, we'd never know as we don't test this case anywhere else. I
prefer that we mark it (and the other test in that class as \@Nightly).
> Let SolrCore be the only thing which registers/unregisters a config directory
> listener
> --------------------------------------------------------------------------------------
>
> Key: SOLR-7408
> URL: https://issues.apache.org/jira/browse/SOLR-7408
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: SOLR-7408.patch, SOLR-7408.patch, SOLR-7408.patch,
> SOLR-7408.patch
>
>
> As reported here: http://markmail.org/message/ynkm2axkdprppgef, there is a
> race condition which results in an exception when creating multiple
> collections over the same config set. I was able to reproduce it in a test,
> although I am only able to reproduce if I put break points and manually
> simulate the problematic context switches.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
