[ 
https://issues.apache.org/jira/browse/LUCENE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560690#comment-14560690
 ] 

Michael McCandless commented on LUCENE-6481:
--------------------------------------------

I committed a small improvement to the test, to sometimes test on a smallish 
random sized bbox, and it hits this new failure:

{noformat}
   [junit4] Started J0 PID(15031@localhost).
   [junit4] Suite: org.apache.lucene.search.TestGeoPointQuery
   [junit4]   1> smallBBox=true
   [junit4]   1> T0: iter=1 id=3 docID=3 lat=-90.2957562284163 
lon=-179.83102465432302 (bbox: lat=-90.84003988710097 TO -89.86198542441215 
lon=-180.5339936365967 TO -179.31722107698667) expected true but got: false 
deleted?=false query=GeoPointInBBoxQuery: field=geoField: Lower Left: 
[-180.5339936365967,-90.84003988710097] Upper Right: 
[-179.31722107698667,-89.86198542441215]
   [junit4]   2> ??? 27, 2015 12:37:04 PM 
com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler
 uncaughtException
   [junit4]   2> WARNING: Uncaught exception in thread: 
Thread[T0,5,TGRP-TestGeoPointQuery]
   [junit4]   2> java.lang.AssertionError: wrong result
   [junit4]   2>        at __randomizedtesting.SeedInfo.seed([5]:0)
   [junit4]   2>        at org.junit.Assert.fail(Assert.java:93)
   [junit4]   2>        at 
org.apache.lucene.search.TestGeoPointQuery$1._run(TestGeoPointQuery.java:372)
   [junit4]   2>        at 
org.apache.lucene.search.TestGeoPointQuery$1.run(TestGeoPointQuery.java:271)
   [junit4]   2> 
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestGeoPointQuery 
-Dtests.method=testRandomTiny -Dtests.seed=5 -Dtests.locale=sr_ME 
-Dtests.timezone=Europe/Vilnius -Dtests.asserts=true 
-Dtests.file.encoding=US-ASCII
   [junit4] ERROR   0.09s | TestGeoPointQuery.testRandomTiny <<<
{noformat}

I'm not sure why testRandomTiny is hitting all these problems!

> Improve GeoPointField type to only visit high precision boundary terms 
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-6481
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6481
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-6481.patch, LUCENE-6481.patch, LUCENE-6481.patch, 
> LUCENE-6481.patch, LUCENE-6481.patch, LUCENE-6481.patch, LUCENE-6481_WIP.patch
>
>
> Current GeoPointField [LUCENE-6450 | 
> https://issues.apache.org/jira/browse/LUCENE-6450] computes a set of ranges 
> along the space-filling curve that represent a provided bounding box.  This 
> determines which terms to visit in the terms dictionary and which to skip. 
> This is suboptimal for large bounding boxes as we may end up visiting all 
> terms (which could be quite large). 
> This incremental improvement is to improve GeoPointField to only visit high 
> precision terms in boundary ranges and use the postings list for ranges that 
> are completely within the target bounding box.
> A separate improvement is to switch over to auto-prefix and build an 
> Automaton representing the bounding box.  That can be tracked in a separate 
> issue.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to