[ https://issues.apache.org/jira/browse/LUCENE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561052#comment-14561052 ]
Michael McCandless commented on LUCENE-6481: -------------------------------------------- I fixed the randomized test case to only test a "smallish" global bbox (up to +/- 1.5 in lat and lon directions)... when testing the full space the test runs very very slowly, even testRandomTiny, because it can require 100s of K terms ... I'm not quite sure why (?) but the query classes do advertise that they should be used on smallish rectangles. Also, the test fails because of boundary cases: {noformat} T0: iter=57 id=6819 docID=6723 lat=-81.12143028547105 lon=-168.98618510239544 (bbox: lat=-81.22948018485512 TO -80.9313958433031 lon=-168.98618505380117 TO -168.77958782241174) expected true but got: false deleted?=false query=GeoPointInBBoxQuery: field=geoField: Lower Left: [-168.98618505380117,-81.22948018485512] Upper Right: [-168.77958782241174,-80.9313958433031] máj 27, 2015 2:16:52 PM com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler uncaughtException WARNING: Uncaught exception in thread: Thread[T0,5,TGRP-TestGeoPointQuery] java.lang.AssertionError: wrong result at __randomizedtesting.SeedInfo.seed([4B5245DED09AE592]:0) at org.junit.Assert.fail(Assert.java:93) at org.apache.lucene.search.TestGeoPointQuery$1._run(TestGeoPointQuery.java:380) at org.apache.lucene.search.TestGeoPointQuery$1.run(TestGeoPointQuery.java:279) {noformat} It's odd because in GeoUtils#bboxContains, we do try to take the quantization into account ... > Improve GeoPointField type to only visit high precision boundary terms > ----------------------------------------------------------------------- > > Key: LUCENE-6481 > URL: https://issues.apache.org/jira/browse/LUCENE-6481 > Project: Lucene - Core > Issue Type: Improvement > Components: core/index > Reporter: Nicholas Knize > Attachments: LUCENE-6481.patch, LUCENE-6481.patch, LUCENE-6481.patch, > LUCENE-6481.patch, LUCENE-6481.patch, LUCENE-6481.patch, LUCENE-6481_WIP.patch > > > Current GeoPointField [LUCENE-6450 | > https://issues.apache.org/jira/browse/LUCENE-6450] computes a set of ranges > along the space-filling curve that represent a provided bounding box. This > determines which terms to visit in the terms dictionary and which to skip. > This is suboptimal for large bounding boxes as we may end up visiting all > terms (which could be quite large). > This incremental improvement is to improve GeoPointField to only visit high > precision terms in boundary ranges and use the postings list for ranges that > are completely within the target bounding box. > A separate improvement is to switch over to auto-prefix and build an > Automaton representing the bounding box. That can be tracked in a separate > issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org