[
https://issues.apache.org/jira/browse/SOLR-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560968#comment-14560968
]
Shalin Shekhar Mangar commented on SOLR-7599:
---------------------------------------------
Here's a list of stuff that should be looked at:
# Does a test really need distribSetUp and distribTearDown methods?
# Usefulness of useJettyDataDir
# solr.xml.persist
# The need to change the value for DirectUpdateHandler2.commitOnClose. Only a
few tests really need it.
# Setting system properties such as System.setProperty("numShards",
Integer.toString(sliceCount));
# checkCreatedVsState -- looks like it is always false across all tests.
> Remove cruft from SolrCloud tests
> ---------------------------------
>
> Key: SOLR-7599
> URL: https://issues.apache.org/jira/browse/SOLR-7599
> Project: Solr
> Issue Type: Task
> Components: SolrCloud, Tests
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 5.3
>
>
> I see many tests which blindly have distribSetUp and distribTearDown methods
> setting a variety of options and system properties that aren't required
> anymore.
> This is because some base test classes have been refactored such that these
> options are redundant. In other cases, people have copied the structure of
> tests blindly instead of understanding what each parameter does.
> Let's try to remove the unnecessary config params from such tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
