[
https://issues.apache.org/jira/browse/SOLR-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561802#comment-14561802
]
Shalin Shekhar Mangar commented on SOLR-7599:
---------------------------------------------
There's an oddity in CloudSolrClientTest which has the following:
{code}
@BeforeClass
public static void beforeSuperClass() {
AbstractZkTestCase.SOLRHOME = new File(SOLR_HOME());
}
{code}
Removing the above fails the test. There is no apparent link between this test
and AbstractZkTestCase.SOLRHOME until I found that this property is used to
setup ZK by the parent base test and that the auto-detected value of
AbstractZkTestCase.SOLRHOME applies only to core tests and not solrj tests. I
have put in this explanation as a comment in that method but we should try to
un-entangle such things in another issue.
> Remove cruft from SolrCloud tests
> ---------------------------------
>
> Key: SOLR-7599
> URL: https://issues.apache.org/jira/browse/SOLR-7599
> Project: Solr
> Issue Type: Task
> Components: SolrCloud, Tests
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 5.3
>
> Attachments: SOLR-7599.patch
>
>
> I see many tests which blindly have distribSetUp and distribTearDown methods
> setting a variety of options and system properties that aren't required
> anymore.
> This is because some base test classes have been refactored such that these
> options are redundant. In other cases, people have copied the structure of
> tests blindly instead of understanding what each parameter does.
> Let's try to remove the unnecessary config params from such tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
