+1 On Thu, May 28, 2015 at 5:38 PM, David Smiley (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/SOLR-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563998#comment-14563998 > ] > > David Smiley commented on SOLR-7599: > ------------------------------------ > > Cleaning up crap like this is usually a thankless task, but I hereby thank > you for it! > >> Remove cruft from SolrCloud tests >> --------------------------------- >> >> Key: SOLR-7599 >> URL: https://issues.apache.org/jira/browse/SOLR-7599 >> Project: Solr >> Issue Type: Task >> Components: SolrCloud, Tests >> Reporter: Shalin Shekhar Mangar >> Assignee: Shalin Shekhar Mangar >> Fix For: Trunk, 5.3 >> >> Attachments: SOLR-7599.patch >> >> >> I see many tests which blindly have distribSetUp and distribTearDown methods >> setting a variety of options and system properties that aren't required >> anymore. >> This is because some base test classes have been refactored such that these >> options are redundant. In other cases, people have copied the structure of >> tests blindly instead of understanding what each parameter does. >> Let's try to remove the unnecessary config params from such tests. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org >
--------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
