[
https://issues.apache.org/jira/browse/LUCENE-6371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564740#comment-14564740
]
Robert Muir commented on LUCENE-6371:
-------------------------------------
{quote}
There's still an extra visit in SpanMTQWrapper, but I think we can fix that by
adding a SpanTermQuery(Term, TermContext) constructor, like we have with the
standard TermQuery. Maybe we should carry this over to LUCENE-6466, as here
it's getting mixed up with the span collection API, which is a separate thing.
I'll put up a patch.
{quote}
OK, this sounds good to me, because it would at least be consistent with
TermQuery.
{quote}
Maybe we should carry this over to LUCENE-6466, as here it's getting mixed up
with the span collection API, which is a separate thing. I'll put up a patch.
{quote}
OK I agree, lets not try to tackle it all at once in one patch. Lets just fix
trunk until we are happy on whatever issues we need. Then we backport
everything to 5.x for 5.3 here.
I have the feeling its really not that far away (your cleanups already here
addressed a lot of my concerns), but it would be good to make sure the api
changes support what we need. Fixing this MTQ termcontext stuff would a great
improvement.
Just as a reminder I am still concerned about LUCENE-6495, which is test
failures introduced from LUCENE-6466 (somehow scoring is changed, and only when
using java 7!!!). This makes life tricky because trunk requires java 8 so we
can't easily dig in. But maybe we can just do a lot of beasting before
backporting the whole thing and try to figure that one out at that time.
> Improve Spans payload collection
> --------------------------------
>
> Key: LUCENE-6371
> URL: https://issues.apache.org/jira/browse/LUCENE-6371
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Paul Elschot
> Assignee: Alan Woodward
> Priority: Minor
> Fix For: Trunk, 5.3
>
> Attachments: LUCENE-6371.patch, LUCENE-6371.patch, LUCENE-6371.patch,
> LUCENE-6371.patch
>
>
> Spin off from LUCENE-6308, see the comments there from around 23 March 2015.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
