[ 
https://issues.apache.org/jira/browse/LUCENE-6371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14577168#comment-14577168
 ] 

Adrien Grand commented on LUCENE-6371:
--------------------------------------

bq.  Or maybe instead we could make SpanCollector implement Cloneable, and move 
the responsibility of building subcollectors directly into NearSpansOrdered?

This sounds better to me, but I'd like to see if we could avoid having to 
implement Cloneable too.

I tried to look more at the way NearSpansOrdered is implemented and it seems to 
me that the only reason why it needs to consume sub spans eagerly is to be able 
to make the match as short as possible. Maybe we could drop this requirement 
and make NearSpansOrdered iterate lazily like NearSpansUnordered? SpanNearQuery 
does not even mention this feature in its javadocs.

> Improve Spans payload collection
> --------------------------------
>
>                 Key: LUCENE-6371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6371
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Paul Elschot
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: Trunk, 5.3
>
>         Attachments: LUCENE-6371.patch, LUCENE-6371.patch, LUCENE-6371.patch, 
> LUCENE-6371.patch, LUCENE-6371.patch, LUCENE-6371.patch
>
>
> Spin off from LUCENE-6308, see the comments there from around 23 March 2015.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to