[
https://issues.apache.org/jira/browse/LUCENE-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14564923#comment-14564923
]
Robert Muir commented on LUCENE-6466:
-------------------------------------
Looks simpler. I am still hoping we can remove the map, but lets do this for
now.
Can we make SpanWeight.buildSimWeight private final? its only used by its ctor.
Can both rewrite methods currently in SpanMultiTermQuery be fixed to avoid
re-seeking? Maybe TopTermsSpanBooleanQueryRewrite was forgotten.
{quote}
What would be nice would be to try and write an asserting TermsEnum that could
check how many times seekExact(BytesRef) was called, to ensure that the various
queries are re-using their term states properly.
{quote}
TermQuery/Weight has checks around this that can help. Look for stuff like
assertTermNotInReader check. This was missing from spans because of its
previous leniency.
> Move SpanQuery.getSpans() to SpanWeight
> ---------------------------------------
>
> Key: LUCENE-6466
> URL: https://issues.apache.org/jira/browse/LUCENE-6466
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Priority: Minor
> Fix For: Trunk, 5.3
>
> Attachments: LUCENE-6466-2.patch, LUCENE-6466.patch,
> LUCENE-6466.patch, LUCENE-6466.patch, LUCENE-6466.patch, LUCENE-6466.patch
>
>
> SpanQuery.getSpans() should only be called on rewritten queries, so it seems
> to make more sense to have this being called from SpanWeight
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
