[
https://issues.apache.org/jira/browse/LUCENE-6466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565009#comment-14565009
]
Robert Muir commented on LUCENE-6466:
-------------------------------------
I only have one more stylish nit, otherwise I like it. Great to remove the
confusing class and also get single-pass spanmultitermquery!
Can we break this very long run-on in SpanTermQuery.buildSimWeight?
{code}
return searcher.getSimilarity().computeWeight(query.getBoost(),
searcher.collectionStatistics(query.getField()), stats);
{code}
Instead I would rename 'stats' to 'termStats' and do maybe something like:
{code}
CollectionStatistics collectionStats = searcher.collectionStatistics(...);
return xxx.computeWeight(query.getBoost(), collectionStats, termStats);
{code}
> Move SpanQuery.getSpans() to SpanWeight
> ---------------------------------------
>
> Key: LUCENE-6466
> URL: https://issues.apache.org/jira/browse/LUCENE-6466
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Priority: Minor
> Fix For: Trunk, 5.3
>
> Attachments: LUCENE-6466-2.patch, LUCENE-6466-2.patch,
> LUCENE-6466.patch, LUCENE-6466.patch, LUCENE-6466.patch, LUCENE-6466.patch,
> LUCENE-6466.patch
>
>
> SpanQuery.getSpans() should only be called on rewritten queries, so it seems
> to make more sense to have this being called from SpanWeight
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
