[
https://issues.apache.org/jira/browse/LUCENE-6547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588206#comment-14588206
]
Nicholas Knize commented on LUCENE-6547:
----------------------------------------
Awesome feedback Mike!
bq. I can see it being considered "OK" to pass "invalid" lat (goes over a pole)
or lon (when it crosses the date line) with the expectation that the API
normlalizes it?
That's only for PointDistance searching. If the radius crosses (after adding
delta lat/lon) the coordinates are normalized and the Spherical intersection is
used. There's a TODO in there to investigate whether its worth adding the math
to "split" the circle into semi-circles at dateline and use BQ. I don't think
it is.
bq. ...can you add "testInvalidXXX" test cases that show we are in fact
throwing excs for the invalid cases?
++ good idea
bq. It seems like there's some dup code, e.g. computeBBox is in both
GeoPointDistanceQuery and GeoPointDistanceQueryImpl?
There is. I noticed this as a side effect from the refactor. I've removed it
and will have that in the next patch (which includes switching PointDistance
radius over to meters instead of Km).
bq. I think it's pretty important to keep testRandom approachable: testRandoms
have a tendency to become disastrous over time.
+++ agree. I can work it in this issue. No need to split into separate issues
since this is all sandboxed anyway?
bq. Can you extend testRandom to test date-line wrapping?
Yes. This is important. I've got it pretty thoroughly tested in ES, but some
beasting is definitely needed.
> Add dateline crossing support to GeoPointInBBox and GeoPointDistance Queries
> ----------------------------------------------------------------------------
>
> Key: LUCENE-6547
> URL: https://issues.apache.org/jira/browse/LUCENE-6547
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/search
> Reporter: Nicholas Knize
> Attachments: LUCENE-6547.patch, LUCENE-6547.patch, LUCENE-6547.patch,
> LUCENE-6547.patch, LUCENE-6547.patch
>
>
> The current GeoPointInBBoxQuery only supports bounding boxes that are within
> the standard -180:180 longitudinal bounds. While its perfectly fine to
> require users to split dateline crossing bounding boxes in two,
> GeoPointDistanceQuery should support distance queries that cross the
> dateline. Since morton encoding doesn't support unwinding this issue will
> add dateline crossing to GeoPointInBBoxQuery and GeoPointDistanceQuery
> classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
