[
https://issues.apache.org/jira/browse/LUCENE-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598796#comment-14598796
]
David Smiley commented on LUCENE-6597:
--------------------------------------
I just took a quick look.
Why does the intersects() method return false when the circle is the world;
shouldn't it return true? Or maybe I'm misunderstanding the semantics.
Do you think it may be worth constructing a special Circle subclass or special
Plane subclass instead, thereby reducing the conditions you added to the
methods? It's certainly no big deal to me; I have no strong opinion; I mostly
wonder what you think. Given how you handled the numerous special cases of
rectangles that are adjacent to poles & what'not as sub-classes, I'm surprised
you didn't take a similar type of approach here.
Can you add a test please? Perhaps make the random test sometimes in a rare
while pick a world circle.
> Geo3d circle creation that covers whole globe throws an
> IllegalArgumentException
> --------------------------------------------------------------------------------
>
> Key: LUCENE-6597
> URL: https://issues.apache.org/jira/browse/LUCENE-6597
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6597.patch
>
>
> The following GeoCircle construction:
> {code}
> new GeoCircle(PlanetModel.SPHERE, -20.0 * RADIANS_PER_DEGREE, -20.0 *
> RADIANS_PER_DEGREE, Math.PI);
> {code}
> ... fails as follows:
> {code}
> Degenerate/parallel vector constructed
> {code}
> The reason is that the plane normal vector cannot be computed in that case.
> A special case is warranted for circles that cover the whole globe.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
