[
https://issues.apache.org/jira/browse/LUCENE-6597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14600656#comment-14600656
]
David Smiley commented on LUCENE-6597:
--------------------------------------
Test looks good.
* What do you think about adding support for zero radius? Might as well;
right? I started to do this to see what happens. First I needed to relax the
arg check in the GeoCircle constructor. But then I found the
SidedPlane.constructNormalizedPerpendicularSidedPlane returned null.
* I noticed GeoCircle computes the cosign of the cutoffAngle but doesn't use it.
* The IllegalArgumentException loop in
Geo3dShapeRectRelationTestCase.testGeoCircleRect can now be removed, it appears.
> Geo3d circle creation that covers whole globe throws an
> IllegalArgumentException
> --------------------------------------------------------------------------------
>
> Key: LUCENE-6597
> URL: https://issues.apache.org/jira/browse/LUCENE-6597
> Project: Lucene - Core
> Issue Type: Bug
> Components: modules/spatial
> Reporter: Karl Wright
> Attachments: LUCENE-6597.patch
>
>
> The following GeoCircle construction:
> {code}
> new GeoCircle(PlanetModel.SPHERE, -20.0 * RADIANS_PER_DEGREE, -20.0 *
> RADIANS_PER_DEGREE, Math.PI);
> {code}
> ... fails as follows:
> {code}
> Degenerate/parallel vector constructed
> {code}
> The reason is that the plane normal vector cannot be computed in that case.
> A special case is warranted for circles that cover the whole globe.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
