[ 
https://issues.apache.org/jira/browse/LUCENE-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14607558#comment-14607558
 ] 

David Smiley commented on LUCENE-6578:
--------------------------------------

FYI I posted to ReviewBoard so that my edits can be seen clearly: 
https://reviews.apache.org/r/36035/

One observation I had, perhaps not introduced in this issue, is that 
GeoPoint.magnitude() should always be 1.0 when using the sphere planet model 
yet the GeoPoint itself doesn't "know" that.  So it goes and computes the 
Math.sqrt and it's cached.  I'm not sure if it's worthwhile, in some issue 
other than this of course, exploring if GeoPoint should have a unit-sphere 
subclass different from the non-unit sphere subclass.  Just a thought.

> Geo3d: arcDistanceToShape() method may be useful
> ------------------------------------------------
>
>                 Key: LUCENE-6578
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6578
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/spatial
>            Reporter: Karl Wright
>         Attachments: LUCENE-6578.patch, LUCENE-6578.patch, LUCENE-6578.patch
>
>
> I've got an application that seems like it may need the ability to compute a 
> new kind of arc distance, from a GeoPoint to the nearest edge/point of a 
> GeoShape.  Adding this method to the interface, and corresponding 
> implementations, would increase the utility of the package for ranking 
> purposes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to